Re: [Qemu-devel] [PATCH 0/5] usb-ccid (v14)

[Blue Swirl]

On Mon, Jan 10, 2011 at 2:32 PM, Alon Levy <address@hidden> wrote:
> On Mon, Jan 10, 2011 at 01:44:32PM +0100, Gerd Hoffmann wrote:
>> On 01/08/11 11:28, Alon Levy wrote:
>> >This patchset adds three new devices, usb-ccid, ccid-card-passthru and
>> >ccid-card-emulated, providing a CCID bus, a simple passthru protocol
>> >implementing card requiring a client, and a standalone emulated card.
>> >
>> >It also introduces a new directory libcaccard with CAC card emulation,
>> >CAC is a type of ISO 7816 smart card.
>> >
>> >Tree for pull: git://anongit.freedesktop.org/~alon/qemu usb_ccid.v14
>>
>> One nit left which I didn't notice on previous reviews:  It can't be
>> disabled at compile time, there is no --disable-smartcard switch.
>> The nss detection needs some tweaks too.  The usual configure
>> behavior in qemu is this:
>>
>>   [ no smarccard option specified ]
>>         autodetect, i.e. enable smartcard if nss support is found,
>>         otherwise disable (i.e. what your patch does now).
>>   --disable-smartcard
>>         turn off smartcard support.
>>   --enable-smartcard
>>         force smartcard support on, if nss isn't present abort
>>         configure with an error message.
>>
>> Otherwise it looks works nicely.  Good job.
>
> Blue Swirl asked me to remove them at v8, so v9+ don't have them. Blue Swirl -
> with or without?

Sorry, Gerd is right and I was wrong.