Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation

[Chris Krumme]

On 01/10/2011 08:31 AM, Markus Armbruster wrote:
> Amit Shah<address@hidden>  writes:
>
> [...]
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index 6fc9b02..168d0f6 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts)
> >           if (!prop->info->parse) {
> >               continue;           /* no way to set it, don't show */
> >           }
> > -        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> > +        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> > +                     prop->info->name, prop->desc ?: "");
Hello Amit,

Do we want to add the GCCism here of ?:?

Thanks

Chris

> >       }
> >       return 1;
> >   }
> Output could be made prettier (align the help texts).  Preferrably in a
> follow-up commit, because this one's seen enough respins already.
>
> [...]