Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev properties for documentation

[Amit Shah]

On (Mon) Jan 10 2011 [18:01:58], Chris Krumme wrote:
> On 01/10/2011 08:31 AM, Markus Armbruster wrote:
> >Amit Shah<address@hidden>  writes:
> >
> >[...]
> >>diff --git a/hw/qdev.c b/hw/qdev.c
> >>index 6fc9b02..168d0f6 100644
> >>--- a/hw/qdev.c
> >>+++ b/hw/qdev.c
> >>@@ -185,7 +185,8 @@ int qdev_device_help(QemuOpts *opts)
> >>          if (!prop->info->parse) {
> >>              continue;           /* no way to set it, don't show */
> >>          }
> >>-        error_printf("%s.%s=%s\n", info->name, prop->name, 
> >>prop->info->name);
> >>+        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> >>+                     prop->info->name, prop->desc ?: "");
> Hello Amit,
> 
> Do we want to add the GCCism here of ?:?

We already depend on a lot of gcc-specific things, and I believe we have
?: elsewhere as well.

                Amit