[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile |
Date: |
Wed, 12 Jan 2011 11:22:08 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jan 11, 2011 at 10:12:17PM +0000, Peter Maydell wrote:
> M profile ARM cores don't have a CPSR mode field. Set the bit in the
> TB flags that indicates non-user mode correctly for these cores.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/cpu.h | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
Reviewed-by: Aurelien Jarno <address@hidden>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 3adb118..3cd69c4 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -472,13 +472,19 @@ static inline void cpu_clone_regs(CPUState *env,
> target_ulong newsp)
> static inline void cpu_get_tb_cpu_state(CPUState *env, target_ulong *pc,
> target_ulong *cs_base, int *flags)
> {
> + int privmode;
> *pc = env->regs[15];
> *cs_base = 0;
> *flags = (env->thumb << ARM_TBFLAG_THUMB_SHIFT)
> | (env->vfp.vec_len << ARM_TBFLAG_VECLEN_SHIFT)
> | (env->vfp.vec_stride << ARM_TBFLAG_VECSTRIDE_SHIFT)
> | (env->condexec_bits << ARM_TBFLAG_CONDEXEC_SHIFT);
> - if ((env->uncached_cpsr & CPSR_M) != ARM_CPU_MODE_USR) {
> + if (arm_feature(env, ARM_FEATURE_M)) {
> + privmode = !((env->v7m.exception == 0) && (env->v7m.control & 1));
> + } else {
> + privmode = (env->uncached_cpsr & CPSR_M) != ARM_CPU_MODE_USR;
> + }
> + if (privmode) {
> *flags |= ARM_TBFLAG_PRIV_MASK;
> }
> if (env->vfp.xregs[ARM_VFP_FPEXC] & (1 << 30)) {
> --
> 1.6.3.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile, Peter Maydell, 2011/01/11
- Re: [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 6/8] target-arm: Translate with condexec bits from TB flags, not CPUState, Peter Maydell, 2011/01/11