[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState |
Date: |
Wed, 12 Jan 2011 11:22:13 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jan 11, 2011 at 10:12:18PM +0000, Peter Maydell wrote:
> When translating, get the user/priv state from the TB flags, not
> the CPUState.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/translate.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
Reviewed-by: Aurelien Jarno <address@hidden>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 4fe202d..aa3c60a 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -9078,11 +9078,7 @@ static inline void
> gen_intermediate_code_internal(CPUState *env,
> dc->condexec_mask = (ARM_TBFLAG_CONDEXEC(tb->flags) & 0xf) << 1;
> dc->condexec_cond = ARM_TBFLAG_CONDEXEC(tb->flags) >> 4;
> #if !defined(CONFIG_USER_ONLY)
> - if (IS_M(env)) {
> - dc->user = ((env->v7m.exception == 0) && (env->v7m.control & 1));
> - } else {
> - dc->user = (env->uncached_cpsr & 0x1f) == ARM_CPU_MODE_USR;
> - }
> + dc->user = (ARM_TBFLAG_PRIV(tb->flags) == 0);
> #endif
> dc->vfp_enabled = ARM_TBFLAG_VFPEN(tb->flags);
> dc->vec_len = ARM_TBFLAG_VECLEN(tb->flags);
> --
> 1.6.3.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState, (continued)
- [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState, Peter Maydell, 2011/01/11
- Re: [Qemu-devel] [PATCH 8/8] target-arm: Translate with user-state from TB flags, not CPUState,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 6/8] target-arm: Translate with condexec bits from TB flags, not CPUState, Peter Maydell, 2011/01/11
- Re: [Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on TB flags, not CPUState, Aurelien Jarno, 2011/01/14