qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 0/5] iohandlers: Add support for enabling/disabl


From: Gerd Hoffmann
Subject: [Qemu-devel] Re: [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers
Date: Thu, 13 Jan 2011 15:04:27 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7

On 01/13/11 14:00, Amit Shah wrote:
Hi,

This patchset adds new interfaces to work with iohandlers.  It adds:

int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque)
    -- Specify io handlers for an fd
int remove_fd_handlers(int fd)
    -- Remove fd handlers for fd (mark ioh for deletion)
int set_read_poll_fd_action(int fd, bool enable)
    -- Enable or disable the fd_read_poll fd handler
int set_read_fd_action(int fd, bool enable)
    -- Enable or disable the fd_read fd handler
int set_write_fd_action(int fd, bool enable)
    -- Enable or disable the fd_read fd handler

A new struct, IOHandlerOps, is added, to collect all the ops together
instead of passing individual ones to functions.

The older function, qemu_set_fd_handler2(), is now a wrapper to
assign_fd_handlers()  and can be deprecated by converting the existing
usage to assign_fd_handlers().

Looks good overall, just some minor nits, see replies to individual patches.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]