|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually |
Date: | Thu, 13 Jan 2011 15:53:15 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7 |
Hi,
I can't see such a race window given that most qemu code runs serialized anyway. If you call assign_fd_handlers() + set_write_fd_action(false) in sequence I can't see how a select call can happen inbetween ...Not today, but later when we have threads doing this stuff?
Unlikely I think. Seems we will go offload specific tasks to threads using threadlets (especially in the block layer), but I expect the main even loop will not be splitted into multiple threads.
Should I just leave a comment to take care of this for later?
Thats fine I guess. Or maybe add arguments to assign_fd_handlers() with the initial state.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |