[Qemu-devel] Re: [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n

[Paolo Bonzini]

On 01/13/2011 06:28 PM, David Ahern wrote:
> > > @@ -1087,8 +1087,10 @@ void pc_vga_init(PCIBus *pci_bus)
> > >        } else if (std_vga_enabled) {
> > >            if (pci_bus) {
> > >                pci_vga_init(pci_bus);
> > > +#ifdef CONFIG_VGA_ISA
> > >            } else {
> > >                isa_vga_init();
> > > +#endif
> >
> > Should this be an abort for #ifndef CONFIG_VGA_ISA?  And maybe the isapc
> > machine should be disabled altogether?
> >
> > Paolo
>
> If that's desired I can change that to:
>
> #ifdef CONFIG_VGA_ISA
>           } else {
>               isa_vga_init();
> #else
>               abort();
> #endif

Please check if you can trigger the abort via -M isapc (I think so, but 
I'm not sure).  If I am correct, the better solution is to disable isapc.

Paolo