Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files

[David Ahern]

On 01/14/11 13:31, Blue Swirl wrote:
> On Fri, Jan 14, 2011 at 8:24 PM, David Ahern <address@hidden> wrote:
>>
>>
>> On 01/14/11 13:17, Blue Swirl wrote:
>>> On Fri, Jan 14, 2011 at 7:12 PM, David Ahern <address@hidden> wrote:
>>>> Currently, device config settings in the default-configs file are not 
>>>> propogated into the config*.h files. While the Makefile rules observe them 
>>>> through the *.mak files, the CONFIG options are not usable within the .c 
>>>> files.
>>>>
>>>> This patch adds the settings to the header files. To do that the host 
>>>> devices make file is renamed to config-host-devices.mak and the target 
>>>> devices mak file to config-target-devices.mak.
>>>
>>> NACK, see this thread for the previous discussion:
>>> http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg02268.html
>>
>> hmm.... so there is no interest in making the existing design actually
>> work? It's reinvent the config design or nothing?
>>
>> I'm looking to compile out all device models not relevant to my use case.
> 
> That's OK, but the correct fix is to change the design of the machine
> model to something more advanced where the unwanted objects are simply
> not linked in, without any changes to board code. This is not so
> trivial and also many devices are not architecturally clean yet.

A lot of changes are need to obtain that goal, and I am not the right
person to do them. Until that ideal design can be developed and
implemented why not take a small patch that fixes the existing design?
It's not a major change -- a very small one actually (4 files, 13 lines
modified).

David