[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize |
Date: |
Mon, 17 Jan 2011 10:14:46 +0100 |
User-agent: |
Mutt/1.3.28i |
> Do we want to check to ensure the size_changed flag isn't set before
> doing a second resize event? I'm wondering if the truncate takes
> $longtime and user gets impatient and issues a second resize command.
> How should we respond? Ignore it? queue it up?
The truncate is synchronous and the monitor command won't return before
it's done. The interfact might be a bit cleaner if we'd just pass the
reason for the change callback as another argument. I'll do that for
the next respin.
> Is there any other path that invokes bdrv_truncate? If so, do we want
> invoke the call back in those scenarios or only if the truncate is
> initiated from the monitor invocation?
Currently only the qemu-img and qemu-io tools invooke bdrv_truncate.
But if we grow new users we should always tell the driver/guest about it
so that it knows about the size change.
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, (continued)
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/17
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/18
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize, Christoph Hellwig, 2011/01/14
[Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes, Christoph Hellwig, 2011/01/14
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices, Luiz Capitulino, 2011/01/18