Re: [Qemu-devel] Re: [PATCH] usb-msd: Add usb-storage, removable=on|off property

[Stefan Hajnoczi]

On Mon, Jan 17, 2011 at 4:01 PM, Christoph Hellwig <address@hidden> wrote:
> On Mon, Jan 17, 2011 at 10:04:05AM +0000, Stefan Hajnoczi wrote:
>> I was considering not using bdrv_set_removable() and instead adding a
>> hint to the BlockDriverState which gets checked when constructing the
>> SCSI INQUIRY response.  If we take that approach, then QEMU doesn't
>> consider the block device removable in the eject/change medium sense.
>
> I think that's the better approach.  What about moving the removable
> qdev property up from the usb driver into the scsi-disk driver?  That's
> where it logically belongs, and avoids the need to add another hint.

That could work although the plumbing to get us to the point where a
scsi-disk qdev is created isn't very pretty either.  I'll try adding a
removable property and setting it in a sane way.

Stefan