[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadl
From: |
Arun R Bharadwaj |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API |
Date: |
Tue, 18 Jan 2011 12:16:46 +0530 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
* Stefan Hajnoczi <address@hidden> [2011-01-18 06:31:34]:
> On Tue, Jan 18, 2011 at 4:43 AM, Arun R Bharadwaj
> <address@hidden> wrote:
> > * Stefan Hajnoczi <address@hidden> [2011-01-17 09:56:58]:
> >
> >> On Thu, Jan 13, 2011 at 12:14 PM, Arun R Bharadwaj
> >> <address@hidden> wrote:
> >> > +static void threadlet_io_completion_signal_handler(int signum)
> >> > +{
> >> > + qemu_service_io();
> >> > +}
> >> > +
> >> > +static void threadlet_register_signal_handler(void)
> >> > +{
> >> > + struct sigaction act;
> >> > + sigfillset(&act.sa_mask);
> >> > + act.sa_flags = 0; /* do not restart syscalls to interrupt select()
> >> > */
> >> > + act.sa_handler = threadlet_io_completion_signal_handler;
> >> > + sigaction(SIGUSR2, &act, NULL);
> >> > +}
> >> > +
> >> > +void threadlet_init(void)
> >> > +{
> >> > + threadlet_register_signal_handler();
> >> > +}
> >>
> >> This would be the right place to create qemu-threadlet.c, instead of
> >> adding the thread_init() prototype to qemu-thread.h and then including
> >> that in vl.c.
> >>
> >> Stefan
> >
> > I did not follow your comment here. How can we avoid including
> > threadler_init() in vl.c?
>
> Instead of adding threadlet_init() and related functions to
> posix-aio-compat.c and adding the prototype to qemu-thread.h, why not
> just create qemu-threadlet.c/qemu-threadlet.h and put these functions
> there instead?
>
> Stefan
Got it. So you mean I merge patch 8 and patch 10 into a single patch.
But wouldn't this mean we are moving code and adding new API in the
same patch? Anthony did not want this from what I recall. But I can do
it if you feel it makes things simple.
-arun
- [Qemu-devel] [PATCH 04/12] Add ThreadletQueue., (continued)
- [Qemu-devel] [PATCH 04/12] Add ThreadletQueue., Arun R Bharadwaj, 2011/01/13
- [Qemu-devel] [PATCH 05/12] Threadlet: Add submit_work threadlet API., Arun R Bharadwaj, 2011/01/13
- [Qemu-devel] [PATCH 06/12] Threadlet: Add dequeue_work threadlet API and remove active field., Arun R Bharadwaj, 2011/01/13
- [Qemu-devel] [PATCH 07/12] Remove thread_create routine., Arun R Bharadwaj, 2011/01/13
- [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Arun R Bharadwaj, 2011/01/13
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Stefan Hajnoczi, 2011/01/17
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Arun R Bharadwaj, 2011/01/17
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Stefan Hajnoczi, 2011/01/18
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API,
Arun R Bharadwaj <=
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Stefan Hajnoczi, 2011/01/18
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Venkateswararao Jujjuri (JV), 2011/01/18
- Re: [Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API, Stefan Hajnoczi, 2011/01/19
[Qemu-devel] [PATCH 09/12] Remove all instances of CONFIG_THREAD, Arun R Bharadwaj, 2011/01/13
[Qemu-devel] [PATCH 10/12] Move threadlet code to qemu-threadlets.c, Arun R Bharadwaj, 2011/01/13
[Qemu-devel] [PATCH 11/12] Threadlets: Add functionality to create private queues., Arun R Bharadwaj, 2011/01/13
[Qemu-devel] [PATCH 12/12] Threadlets: Add documentation, Arun R Bharadwaj, 2011/01/13
Re: [Qemu-devel] [PATCH 00/12] Threadlets Infrastructure., Stefan Hajnoczi, 2011/01/17