[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices |
Date: |
Tue, 18 Jan 2011 10:35:39 -0200 |
On Fri, 14 Jan 2011 17:20:44 +0100
Christoph Hellwig <address@hidden> wrote:
> This patchset adds support for online resizing of block devices.
>
> The first patch adds a new resize monitor command which call into
> the existing image resize code. This is the meat of the series
> and probably needs quite a bit of review and help as I'm not sure
> about how to implement the error handling for monitor commands
> correctly. Am I really supposed to add a new QERR_ definition
> for each possible error? And if yes how am I supposed to define
> them? The macros for them aren't exactly self-explaining.
Well, what happens is this: we screwed up with that interface and we
should replace it soon.
I see you're not adding the new command in QMP (only in the human monitor),
is that intentional? (qmp commands are added to the qmp-commands.hx file).
If it's intentional, then using only error_report() should be ok. If you
plan to have a qmp version, then we'll have to choose between reporting
a generic error version to the client, which is what's going to happen if
you use error_report(), or add the QERR_ macros.
Markus, what do you think? I feel it's pretty urgent for us to replace
that interface.
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, (continued)
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/18
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Kevin Wolf, 2011/01/19
- Re: [Qemu-devel] [PATCH 1/3] block: add resize monitor command, Christoph Hellwig, 2011/01/19
[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize, Christoph Hellwig, 2011/01/14
[Qemu-devel] [PATCH 3/3] virtio-blk: tell the guest about size changes, Christoph Hellwig, 2011/01/14
Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices,
Luiz Capitulino <=