Re: [Qemu-devel] [PATCH 0/3] allow online resizing of block devices

[Luiz Capitulino]

On Tue, 18 Jan 2011 13:48:06 +0100
Christoph Hellwig <address@hidden> wrote:

> On Tue, Jan 18, 2011 at 10:35:39AM -0200, Luiz Capitulino wrote:
> > Well, what happens is this: we screwed up with that interface and we
> > should replace it soon.
> > 
> > I see you're not adding the new command in QMP (only in the human monitor),
> > is that intentional? (qmp commands are added to the qmp-commands.hx file).
> > 
> > If it's intentional, then using only error_report() should be ok. If you
> > plan to have a qmp version, then we'll have to choose between reporting
> > a generic error version to the client, which is what's going to happen if
> > you use error_report(), or add the QERR_ macros.
> 
> No, I hoped this would also add the QMP interface.  Why do we need to
> declare the commands twice?

Because they're different interfaces and should not be tied to each other,
they have different name spaces for example and commands in QMP might have
no relation to commands in HMP and vice-versa.

> Especially as hmp-commands.hx is full of
> magic that makes little sense only for human readable commands.

Yes, the reason for that is that we're in the middle of a refactoring,
but I have around 100 patches that makes a clean separation between the
two and creates a cleaner interface (specially for HMP).

> Any help on how to define the QERR_ macros?

I think we should emit a generic error in QMP for now, I don't think it's
a good idea to expend the bad interface we have today.