qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() st


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch() statement
Date: Tue, 18 Jan 2011 10:50:47 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10

On 01/18/2011 03:20 AM, Markus Armbruster wrote:
address@hidden writes:

From: Jes Sorensen<address@hidden>

Signed-off-by: Jes Sorensen<address@hidden>
---
  cutils.c |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/cutils.c b/cutils.c
index 328738c..f2c8bbd 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, 
const char default_suffix)
          }
      }
      switch (toupper(d)) {
-    case 'B':
+    case STRTOSZ_DEFSUFFIX_B:
          mul = 1;
          if (mul_required) {
              goto fail;
          }
          break;
-    case 'K':
+    case STRTOSZ_DEFSUFFIX_KB:
          mul = 1<<  10;
          break;
      case 0:
          if (mul_required) {
              goto fail;
          }
-    case 'M':
+    case STRTOSZ_DEFSUFFIX_MB:
          mul = 1ULL<<  20;
          break;
-    case 'G':
+    case STRTOSZ_DEFSUFFIX_GB:
          mul = 1ULL<<  30;
          break;
-    case 'T':
+    case STRTOSZ_DEFSUFFIX_TB:
          mul = 1ULL<<  40;
          break;
      default:
And this improves what?  Certainly not clarity.

In my opinion, the STRTOSZ_DEFSUFFIX_TB are useless chaff.  Chacun à son
goût.

Yeah, I have to agree.  I'm not of the literals are evil camp.

BTW, a useful change would be to accept both upper and lower case letters.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]