qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Support saturation with shift=0.


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] Support saturation with shift=0.
Date: Wed, 19 Jan 2011 16:51:44 +0000

On 19 January 2011 16:10, Christophe Lyon <address@hidden> wrote:
>
> This patch fixes corner-case saturations, when the target range is
> zero. It merely removes the guard against (sh == 0), and makes:
> __ssat(0x87654321, 1) return 0xffffffff and set the saturation flag

did you mean __ssat(0x87654321, 0) here? (they give the same
result, of course, but it's the sh==0 case the patch is changing...)

> __usat(0x87654321, 0) return 0 and set the saturation flag
>
> Signed-off-by: Christophe Lyon <address@hidden>

Checked against the ARM ARM and tested by
random-instruction-sequence generation.

(We could have taken the opportunity of adding braces to
conform to the coding style while touching these lines, but
since the patch isn't changing them, just reindenting, I'm
happy not to worry about this.)

Reviewed-by: Peter Maydell <address@hidden>
(for the content of the patch if not the commit message, anyway).

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]