Re: [Qemu-devel] [PATCH] target-arm: Fix garbage collection of temporaries in Neon emulation.

[Peter Maydell]

On 19 January 2011 14:37, Christophe Lyon <address@hidden> wrote:
> Here is an updated patch which will hopefully not be mangled by my mailer.
>
> Fix garbage collection of temporaries in Neon emulation.

I've tested this patch and it does indeed fix the problems with VMULL
and friends (I was seeing assertions/hangs). I've tested with random
instruction sequence generation and with this patch the non-scalar
forms of VMLAL, VMLSL, VQDMLAL, VQDMLSL, VMULL, VQDMULL
now all pass. The scalar forms now pass random-sequence testing
with the addition of a patch from the qemu-meego tree. Since I have
effectively just tested that meego patch I'll post it to the list in
a moment.

Reviewed-by: Peter Maydell <address@hidden>

I would personally prefer slightly less terse commit messages
(for instance it might be nice to list the affected instructions in
this case). The convention is also to preface the summary line
with the file or directory affected, ie "target-arm: Fix garbage
collection of temporaries in Neon emulation".

-- PMM