|
| From: | Gerd Hoffmann |
| Subject: | Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state |
| Date: | Fri, 21 Jan 2011 09:46:10 +0100 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7 |
Hi,
By the way, we don't have a QEMUState but instead use globals.
/me wants to underline this.IMO it is absolutely pointless to worry about ways to pass around kvm_state. There never ever will be a serious need for that.
We can stick with the current model of keeping global state in global variables. And just do the same with kvm_state.
Or we can move to have all state in a QEMUState struct which we'll pass around basically everywhere. Then we can simply embed or reference kvm_state there.
I'd tend to stick with the global variables as I don't see the point in having a QEMUstate. I doubt we'll ever see two virtual machines driven by a single qemu process. YMMV.
cheers, Gerd
| [Prev in Thread] | Current Thread | [Next in Thread] |