[Qemu-devel] Re: [PATCH 3/5] blockdev: Reject multiple definitions for the same drive

[Markus Armbruster]

Kevin Wolf <address@hidden> writes:

> Am 17.01.2011 19:31, schrieb Markus Armbruster:
>> For reasons lost in the mist of time, we silently ignore multiple
>> definitions for the same drive:
>> 
>>     $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive 
>> if=ide,index=1,file=tmp.qcow2 -drive if=ide,index=1,file=nonexistant
>>     QEMU 0.13.50 monitor - type 'help' for more information
>>     (qemu) info block
>>     ide0-hd1: type=hd removable=0 file=tmp.qcow2 backing_file=tmp.img ro=0 
>> drv=qcow2 encrypted=0
>> 
>> With if=none, this can become quite confusing:
>> 
>>     $ qemu-system-x86_64 -nodefaults -vnc :1 -S -monitor stdio -drive 
>> if=none,index=1,file=tmp.qcow2,id=eins -drive 
>> if=none,index=1,file=nonexistant,id=zwei -device ide-drive,drive=eins 
>> -device ide-drive,drive=zwei
>>     qemu-system-x86_64: -device ide-drive,drive=zwei: Property 
>> 'ide-drive.drive' can't find value 'zwei'
>> 
>> The second -device fails, because it refers to drive zwei, which got
>> silently ignored.
>> 
>> Make multiple drive definitions fail cleanly.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Dropped this one (and patch 5, which depends on it) from the block
> branch again, it breaks -cdrom and probably other drives which are
> created by default.

--verbose?

I was wondering what crap could depend on the crazy silent ignore...