[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: add ppoll syscall support
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: add ppoll syscall support |
|
Date: |
Sun, 23 Jan 2011 21:25:10 +0000 |
On 23 January 2011 19:56, Mike Frysinger <address@hidden> wrote:
> Some architectures (like Blackfin) only implement ppoll (and skip poll).
> So add support for it using existing poll code.
This looks wrong -- ppoll() is supposed to be atomic, but
your implementation isn't. Why can't we just implement this
by calling the host ppoll? (might need a configure test, but
that's straightforward.)
-- PMM