Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver

[Anthony Liguori]

On 01/21/2011 09:09 PM, Chunqiang Tang wrote:
> > Coding style.
> >
> > In general, I like the idea of the simulator but the coding style is off
> >      
>    
> > quite a bit.
> >      
> Please be specific and I would be happy to take suggestions. The header
> issue should be easy to fix.
>    

Read CODING_STYLE and go through your code.

The code pretty consistently doesn't follow it.

Regards,

Anthony Liguori