Re: [Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3

[Fabien Chouteau]

On 01/21/2011 08:04 PM, Blue Swirl wrote:
> On Fri, Jan 21, 2011 at 5:00 PM, Fabien Chouteau<address@hidden>  wrote:
> > Hello Qemu-devel,
> >
> > Here is the third version of Leon3 emulation patch-set.
> >
> > Modifications since v2:
> >   - Tracepoints
> >   - DEFINE_PROP_* macros
> >   - New interface to trigger interrupts on Leon3 (set_pil_in:leon3.c)
> >   - Minor reformating
> >
> > Please feel free to comment.
>
> The patches look fine to me now, except 4/5 had a small problem.
>
> Could you run them through checkpatch.pl and fix the issues? The lines
> like //#define DEBUG_LEON3 can stay despite the error if you don't
> convert them to tracepoints.

Sure, I will fix the two problems that you pointed out and run checkpatch.pl
to fix the remaining style issues.

--
Fabien Chouteau