[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] loader: memory leak in rom_add_file() on error
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] loader: memory leak in rom_add_file() on error path |
|
Date: |
Mon, 24 Jan 2011 15:09:48 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Isaku Yamahata <address@hidden> writes:
> fix memory leak in rom_add_file().
>
> Signed-off-by: Isaku Yamahata <address@hidden>
> ---
> hw/loader.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/loader.c b/hw/loader.c
> index 35d792e..6cba8c5 100644
> --- a/hw/loader.c
> +++ b/hw/loader.c
> @@ -618,6 +618,8 @@ int rom_add_file(const char *file, const char *fw_dir,
> err:
> if (fd != -1)
> close(fd);
> + qemu_free(rom->fw_file);
> + qemu_free(rom->fw_dir);
> qemu_free(rom->data);
> qemu_free(rom->path);
> qemu_free(rom->name);
Reviewed-by: Markus Armbruster <address@hidden>