[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1
From: |
Chunqiang Tang |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 |
Date: |
Mon, 24 Jan 2011 09:50:24 -0500 |
> I think the root of the problem is that your series didn't maintain
> bisectability.
>
> IOW, each patch needs to be able to be applied one at a time such that
> at each point, the build doesn't break and functionality doesn't break.
>
> Otherwise, tools like git bisect don't work.
This was true with the old, big FVD patches you reviewed. Following
Christoph Hellwig's suggestion, the new series of FVD patches submitted
last Friday, e.g., "FVD: Added the simulated 'blksim' driver", add
individual smaller functions and breaks neither compilation nor execution.
- Re: [Qemu-devel] [PATCH 3/5] Fast Virtual Disk (FVD) Proposal Part 3, (continued)
Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1, Anthony Liguori, 2011/01/21