[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver
From: |
Chunqiang Tang |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver |
Date: |
Mon, 24 Jan 2011 10:07:52 -0500 |
> Read CODING_STYLE and go through your code.
Went through CODING_STYLE. The white space issue in FVD was already been
fixed previously. FVD’s variable and type names are fine, and line width
is fine. The only remaining issue in FVD is '}' before 'else', which will
be fixed. CODING_STYLE does not require, but I noticed through example
that, function calls are 'do_something()', while FVD uses 'do_something
()' (with a white space before '()'). Is this a hard requirement and need
be fixed? Is there anything else that are not specified in CODING_STYLE
but is adopted in QEMU by convention? I would like to take all suggestions
and fix code style in one pass, rather than doing it again and again.
Thanks.
CODING_STYLE:
if (a == 5) {
} else if (a == 6) {
}
FVD:
if (a == 5) {
}
else if (a == 6) {
}
Re: [Qemu-devel] [PATCH 1/3] FVD: Added support for 'qemu-img update', Stefan Hajnoczi, 2011/01/28