|
From: | Paolo Bonzini |
Subject: | [Qemu-devel] Re: [PATCH v2] savevm: fix corruption in vmstate_subsection_load(). |
Date: | Mon, 24 Jan 2011 16:35:12 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 01/24/2011 10:30 AM, Yoshiaki Tamura wrote:
Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 which is the marker of subsection, the loader gets corrupted because vmstate_subsection_load() continues even the device doesn't require it. This patch adds a checker whether subsection is needed, and skips following routines if not needed. Signed-off-by: Yoshiaki Tamura<address@hidden>
VMS_STRUCT is a can of worms, since almost all uses of subsections _are_ VMS_STRUCTs. So almost all uses of subsections have ambiguous parsing. :/
So, for now, Acked-by: Paolo Bonzini <address@hidden> Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |