RE: [Qemu-devel] [PATCH] Correct win32 timers deleting

[Pavel Dovgaluk]

> > diff --git a/qemu-timer.c b/qemu-timer.c index 95814af..548f2e5
> 100644
> > --- a/qemu-timer.c
> > +++ b/qemu-timer.c
> > @@ -972,7 +972,10 @@ static int win32_start_timer(struct
> qemu_alarm_timer
> > *t)
> 
> Your patch is broken here.

 I checked the patch file, my "sent items" folder in outlook. This line is
not broken in both places.
 But when I receive my patch from "qemu-devel" list, this line is broken.
 Do you have any ideas about that?

> 
> > - timeKillEvent(data->timerId);
> > - timeEndPeriod(data->period);
> > + if (data->timerId)
> > + timeKillEvent(data->timerId);
> > + if (data->period)
> > + timeEndPeriod(data->period);
> 
> CODING_STYLE requires {} for both if statements.

 Ok, inserted in new version.

> 
> Please check your patch using scripts/checkpatch.pl.
> 

 Now this script says, that patch is ok.


Pavel Dovgaluk