Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

[Jes Sorensen]

On 01/25/11 11:17, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
> 
>> On 01/24/11 18:47, Markus Armbruster wrote:
>>> Jes Sorensen <address@hidden> writes:
>>>>>>> qemu_toupper() - whats the problem?
>>>>> If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
>>>>> will not match any input.
>>>>
>>>> Right, so one has to be careful when adding new suffix constants.
>>>
>>> Calls for a comment right next to the definition of the
>>> STRTOSZ_DEFSUFFIX_T*.
>>>
>>> I hate unstated restrictions that are hidden far away from the place
>>> where you can break them.
>>
>> Well I am fine with a comment in the code.
> 
> Such a comment improves it from "wrong" to merely "ugly".  I can live
> with that.

I realize that you view it as such, in other eyes it goes from hackish
to correct ... there is zero point in arguing over this, we can just
agree to disagree.

Jes