Re: [Qemu-devel] [PATCH 0/3 v3] allow online resizing of block devices

[Kevin Wolf]

Am 24.01.2011 13:32, schrieb Christoph Hellwig:
> This patchset adds support for online resizing of block devices.
> 
> The first patch adds a new resize monitor command which call into
> the existing image resize code.  This is the meat of the series
> and probably needs quite a bit of review and help as I'm not sure
> about how to implement the error handling for monitor commands
> correctly.  Am I really supposed to add a new QERR_ definition
> for each possible error?  And if yes how am I supposed to define
> them?  The macros for them aren't exactly self-explaining.
> 
> The second patch adds a way to tell drivers about a resize, and the
> third one adds a guest notification for config changes to virtio-blk
> which allows the guest to pick it up without a rescan.  I've just sent
> the corresponding Linux guest driver patch to Rusty.
> 
> Changes from version 2 to version 3:
>  - add missing braces
>  - use device as the argument name for the device string
>  - also rename the HMP version of the command to block_resize
> 
> Changes from version 1 to version 2:
>  - also add a QMP command (block_resize)
>  - use the o format for the size in the monitor command
>  - fix typos
>  - use QERR_UNDEFINED_ERROR for errors instead of unstructured strings
>  - remove the CDROM hint check
>  - add a reason argument to the change callback
> ---end quoted text---

Thanks, applied all to the block branch.

Kevin