qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: Proposal: Improving patch tracking and review using Rie


From: Paolo Bonzini
Subject: [Qemu-devel] Re: Proposal: Improving patch tracking and review using Rietveld
Date: Thu, 27 Jan 2011 11:25:39 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 01/26/2011 08:56 PM, Diego Novillo wrote:
At Google we use a code review tool which was open sourced a couple of
years ago: Rietveld
(http://code.google.com/appengine/articles/rietveld.html).

The best way of thinking about it is "bugzilla for patches".  The
system creates an entry for every patch submitted, provides a web tool
for manipulating the patch (comments, different views of the diff,
highlighting, etc) and it also has an email gateway.

We have discussed patch tracking mechanisms in the past, and none so
far has taken hold.  The reason why I like Rietveld is that it doesn't
really matter whether we all switch to using it at once:

1- Rietveld always send the patch sent to it to gcc-patches@ (provided
the submitter added gcc-patches to the CC list).
2- The whole trail of discussion on the patch also get sent to
gcc-patches and everyone else is CC'd in it.
3- Reviewers do not need to use the web tool to reply to the patch.
One can simply respond to the e-mail, and it will get added to the
patch discussion trail.

How does this work WRT multiple revisions of the same patch?

I am taking the liberty of CCing qemu-devel since I forwarded your message there.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]