[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: Fix discard command
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: Fix discard command |
Date: |
Fri, 28 Jan 2011 09:56:45 +0000 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Jan 27, 2011 at 01:36:12PM +0100, Kevin Wolf wrote:
> qemu-io passed bytes where it's supposed to pass sectors, so discard requests
> were off.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index 5b24c5e..4470e49 100644
> --- a/qemu-io.c
> +++ b/qemu-io.c
> @@ -1465,7 +1465,7 @@ discard_f(int argc, char **argv)
> }
>
> gettimeofday(&t1, NULL);
> - ret = bdrv_discard(bs, offset, count);
> + ret = bdrv_discard(bs, offset >> BDRV_SECTOR_BITS, count >>
> BDRV_SECTOR_BITS);
Oops, thanks for the fix.
Reviewed-by: Stefan Hajnoczi <address@hidden>