[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] escc: fix interrupt flags
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [PATCH] escc: fix interrupt flags |
Date: |
Fri, 28 Jan 2011 20:53:14 +0000 |
On Thu, Jan 27, 2011 at 7:32 AM, Aurelien Jarno <address@hidden> wrote:
> Recent PowerPC kernel end up in kernel panic during boot in -nographic
> mode. In this mode the second serial port is used as the udbg console,
> and thus a few characters are sent on this port. This activates the
> tx interrupt flag, and later choke the Linux kernel, as it was not
> expecting such a flag to be set.
>
> The problem here comes from the fact that contrary to most devices the
> interrupt flags are only set if the interrupt is enabled. Quoting the
> datasheet: "If the corresponding IE bit is not set, the IP for that
> source of interrupt will never be set."
>
> This patch fixes that by enabling the interrupt flag only when the
> corresponding interrupt is enabled.
>
> Cc: Blue Swirl <address@hidden>
> Signed-off-by: Aurelien Jarno <address@hidden>
Acked-by: Blue Swirl <address@hidden>
Passes also quick tests with Sparc32 and PPC.