[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] new Blackfin QEMU port |
Date: |
Tue, 1 Feb 2011 11:53:14 +0000 |
On 1 February 2011 11:46, Alexander Graf <address@hidden> wrote:
> Ouch. Yes. General rule: never access env from translate.c :).
With the arm target I was tempted to restructure translate.c so
that we copied the handful of "safe" bits of env that we used
into the disas context struct right at the start, and then didn't
pass env into the main translation functions at all. That would
make it much harder to accidentally use bits of env that we
should not, but in the end I decided against it because it would
make my qemu-meego merging job that much harder...
-- PMM