[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconn
From: |
Corentin Chary |
Subject: |
[Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen |
Date: |
Fri, 4 Feb 2011 09:05:53 +0100 |
agraf reported that qemu_mutex_destroy(vs->output_mutex) while failing
in vnc_disconnect_finish().
It's because vnc_worker_thread_loop() tries to unlock the mutex while
not locked. The unlocking call doesn't fail (pthread bug ?), but
the destroy call does.
Signed-off-by: Corentin Chary <address@hidden>
---
ui/vnc-jobs-async.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ui/vnc-jobs-async.c b/ui/vnc-jobs-async.c
index 6e9cf08..0b5d750 100644
--- a/ui/vnc-jobs-async.c
+++ b/ui/vnc-jobs-async.c
@@ -227,6 +227,10 @@ static int vnc_worker_thread_loop(VncJobQueue *queue)
if (job->vs->csock == -1) {
vnc_unlock_display(job->vs->vd);
+ /* output mutex must be locked before going to
+ * disconnected:
+ */
+ vnc_lock_output(job->vs);
goto disconnected;
}
--
1.7.3.4
- [Qemu-devel] [PATCH v3 00/16] vnc: adapative tight, zrle, zywrle, and bitmap module, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 01/16] vnc: qemu can die if the client is disconnected while updating screen,
Corentin Chary <=
- [Qemu-devel] [PATCH v3 02/16] vnc: don't set the quality if lossy encoding are disabled, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 03/16] vnc: add a way to get the update frequency for a given region, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 04/16] vnc: refresh lossy rect after a given timeout, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 05/16] vnc: tight: use the update frequency to choose between lossy and lossless, Corentin Chary, 2011/02/04
- [Qemu-devel] [PATCH v3 06/16] vnc: palette: use a pool to reduce memory allocations, Corentin Chary, 2011/02/04