Re: [Qemu-devel] Re: Porting QEMU to new hosts with unusual ABI (sizeof(long) != sizeof(void *))

[Markus Armbruster]

Stefan Weil <address@hidden> writes:

> Am 05.02.2011 16:35, schrieb Blue Swirl:
[...]
>> The patch changes also signed longs to uintptr_t. That could introduce
>> regressions, so please use signed/unsigned as original.
>
> I changed the code manually, and there was only one location where
> signed/unsigned made a difference. That single case was an int
> parameter passed in a void pointer, and I used intptr_t there.
>
> I had the impression that in the current code (long) was
> sometimes used because it is shorter than (unsigned long) :-)
>
> As long as changes are made manually with the necessary care,
> I'd recommend using uintptr_t where possible.

I'd recommend not to mix up the intptr portability clean up with the
signedness cleanup.  Much easier to review separately.  Moreover,
cleaning up signedness changes generated code, while cleaning up the
types shouldn't (except on hosts where the code doesn't work).
Testable, just don't forget to strip the debug info.

[...]