Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

[Avi Kivity]

On 02/07/2011 05:01 PM, Anthony Liguori wrote:
> typedef struct PeriodicTimer PeriodicTimer;
>
> /**
>  * @accumulated_ticks:  the number of unacknowledged ticks in total 
> since the creation of the timer
>  **/

Outdated comment even before the code is committed.  Will be hard to beat.

> typedef void (PeriodicTimerFunc)(void *opaque);

s/void *opaque/PeriodicTimer *timer/

Down with opaques!

> PeriodicTimer *periodic_timer_new(PeriodicTimerFunc *cb, void *opaque);

void periodic_timer_init(PeriodicTimer *timer, PeriodicTimerFunc *cb);

It is better to embed than to reference.


--
error compiling committee.c: too many arguments to function