qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data
Date: Tue, 08 Feb 2011 01:40:09 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Lightning/1.0b1 Thunderbird/3.0.10

On 02/07/2011 08:55 PM, Amit Shah wrote:
On (Mon) 07 Feb 2011 [20:25:59], Anthony Liguori wrote:
On 02/07/2011 08:14 PM, Amit Shah wrote:
On (Sun) 06 Feb 2011 [11:50:46], Amit Shah wrote:
On (Fri) 04 Feb 2011 [06:52:04], Anthony Liguori wrote:
On 02/04/2011 02:54 AM, Amit Shah wrote:
This can happen if a port gets unplugged before guest has chance to
initialise vqs.

Reported-by: Juan Quintela<address@hidden>
Signed-off-by: Amit Shah<address@hidden>
Applied to master, Thanks.
What's the strategy to commit to 0.14?
Nevermind; saw it in the last pull.
Yes, but if we decide to make this a subsection, we may need to
revert this before the 0.14.0 release because once 0.14.0 goes out,
we can't go back and change it.
Right.

However, virtio doesn't have vmstate yet.  Are we willing to put vmstate
in 0.14 to introduce subsections?  I doubt that.

Not, that's why I suggested reverting this change and pushing it to 0.15. We're not going to fix it properly in 0.14.

Regards,

Anthony Liguori

If that's how you want to approach it, then please send the revert
patches.  The flow_control=0 patches you sent out before definitely
aren't the right approach for migration compatibility.
I understand, I've not looked at that thread yet, but if we want to do
that for 0.14 w/o vmstate, that might be the only way.

                Amit





reply via email to

[Prev in Thread] Current Thread [Next in Thread]