[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [CFT PATCH 08/12] do not use timedwait on qemu_halt_cond
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [CFT PATCH 08/12] do not use timedwait on qemu_halt_cond |
Date: |
Tue, 8 Feb 2011 18:18:25 +0100 |
The following conditions can cause cpu_has_work(env) to become true:
- env->queued_work_first: run_on_cpu is already kicking the VCPU
- env->stop = 1: pause_all_vcpus is already kicking the VCPU
- env->stopped = 0: resume_all_vcpus is already kicking the VCPU
- vm_running = 1: vm_start is calling resume_all_vcpus
- env->halted = 0: see previous patch
- qemu_cpu_has_work(env): when it becomes true, board code should set
env->halted = 0 too.
Signed-off-by: Paolo Bonzini <address@hidden>
---
cpus.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index ee2a6cc..be3d82d 100644
--- a/cpus.c
+++ b/cpus.c
@@ -746,7 +746,7 @@ static void qemu_tcg_wait_io_event(void)
CPUState *env;
while (!any_cpu_has_work())
- qemu_cond_timedwait(tcg_halt_cond, &qemu_global_mutex, 1000);
+ qemu_cond_wait(tcg_halt_cond, &qemu_global_mutex);
qemu_mutex_unlock(&qemu_global_mutex);
@@ -768,7 +768,7 @@ static void qemu_tcg_wait_io_event(void)
static void qemu_kvm_wait_io_event(CPUState *env)
{
while (!cpu_has_work(env))
- qemu_cond_timedwait(env->halt_cond, &qemu_global_mutex, 1000);
+ qemu_cond_wait(env->halt_cond, &qemu_global_mutex);
qemu_kvm_eat_signals(env);
qemu_wait_io_event_common(env);
--
1.7.3.5
- [Qemu-devel] [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 08/12] do not use timedwait on qemu_halt_cond,
Paolo Bonzini <=
- [Qemu-devel] [CFT PATCH 11/12] do not use timedwait on qemu_cpu_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 07/12] always signal pause_cond after stopping a VCPU, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 01/12] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 03/12] inline cpu_halted into sole caller, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 09/12] do not use timedwait on qemu_system_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 12/12] iothread stops the vcpu thread via IPI, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 02/12] cris, microblaze: use cpu_has_work, Paolo Bonzini, 2011/02/08