[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->st
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true |
Date: |
Tue, 08 Feb 2011 21:24:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-02-08 18:18, Paolo Bonzini wrote:
> Sometimes vcpus are stopped directly without going through ->stop = 1.
> Exit the VCPU execution loop in this case as well.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> cpus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index c1d0ceb..5b13961 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1061,7 +1061,7 @@ bool cpu_exec_all(void)
> if (r == EXCP_DEBUG) {
> break;
> }
> - } else if (env->stop) {
> + } else if (env->stop || env->stopped) {
> break;
> }
> }
Hmm, does this path actually trigger? If yes, does it happen to obsolete
the global exit_request hack?
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [CFT PATCH 07/12] always signal pause_cond after stopping a VCPU, (continued)
- [Qemu-devel] [CFT PATCH 07/12] always signal pause_cond after stopping a VCPU, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 01/12] io-thread: make sure to initialize qemu_work_cond and qemu_cpu_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 03/12] inline cpu_halted into sole caller, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 09/12] do not use timedwait on qemu_system_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 12/12] iothread stops the vcpu thread via IPI, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 02/12] cris, microblaze: use cpu_has_work, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 06/12] exit round-robin vcpu loop if cpu->stopped is true, Paolo Bonzini, 2011/02/08
- Re: [Qemu-devel] [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff, Aurelien Jarno, 2011/02/08
- [Qemu-devel] [CFT PATCH 10/12] do not use timedwait on qemu_pause_cond, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 04/12] change qemu_thread_equal API to always compare with current thread, Paolo Bonzini, 2011/02/08
- [Qemu-devel] [CFT PATCH 05/12] always qemu_cpu_kick after unhalting a cpu, Paolo Bonzini, 2011/02/08
- [Qemu-devel] Re: [CFT PATCH 00/12] Tricky parts of my iothread-for-win32 stuff, Jan Kiszka, 2011/02/08