qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)


From: Laurent Vivier
Subject: Re: [Qemu-devel] Re: [PING 0.14] Missing patches (mostly fixes)
Date: Wed, 09 Feb 2011 10:20:38 +0100

>On Sat, Feb 05, 2011 at 10:49:51PM +0100, Laurent Vivier wrote:
>> >On 02/03/2011 12:16 PM, Laurent Vivier wrote:
>> >> And this one ?
>> >>
>> >> linux-user: correct core dump format
>> >>
>> >> http://patchwork.ozlabs.org/patch/78464/
>
>Actually that patch is not ok. The issues you fix on m68k appear
>on arm/eabi after applying your patch. bswap part appears ok, but
>the padding is needed atleast on arm.

It is strange as we have in gdb, if I remember correctly, an explicit check of 
the size of prstatus:

gdb/bfd/elf.c:

    if defined (HAVE_PRSTATUS_T)

    static bfd_boolean
    elfcore_grok_prstatus (bfd *abfd, Elf_Internal_Note *note)
...
      if (note->descsz == sizeof (prstatus_t))
...

How do you test this patch ? Do you use native gdb on ARM ? Because, for m68k, 
cross-compiled gdb does not work (it cannot have sizeof(prstatus_t) for m68k).

Regards,
Laurent


-- 
--------------------- address@hidden  ---------------------
"Tout ce qui est impossible reste à accomplir"    Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard



reply via email to

[Prev in Thread] Current Thread [Next in Thread]