[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/11] qed: Report error for unsupported features
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH 07/11] qed: Report error for unsupported features |
Date: |
Thu, 10 Feb 2011 16:51:22 +0100 |
Instead of just returning -ENOTSUP, generate a more detailed error.
Unfortunately we don't have a helpful text for features that we don't know yet,
so just print the feature mask. It might be useful at least if someone asks for
help.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Acked-by: Stefan Hajnoczi <address@hidden>
---
block/qed.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index 3273448..75ae244 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -14,6 +14,7 @@
#include "trace.h"
#include "qed.h"
+#include "qerror.h"
static void qed_aio_cancel(BlockDriverAIOCB *blockacb)
{
@@ -311,7 +312,13 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
return -EINVAL;
}
if (s->header.features & ~QED_FEATURE_MASK) {
- return -ENOTSUP; /* image uses unsupported feature bits */
+ /* image uses unsupported feature bits */
+ char buf[64];
+ snprintf(buf, sizeof(buf), "%" PRIx64,
+ s->header.features & ~QED_FEATURE_MASK);
+ qerror_report(QERR_UNKNOWN_BLOCK_FORMAT_FEATURE,
+ bs->device_name, "QED", buf);
+ return -ENOTSUP;
}
if (!qed_is_cluster_size_valid(s->header.cluster_size)) {
return -EINVAL;
--
1.7.2.3
- [Qemu-devel] [PULL 00/11] Block patches for master, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 02/11] QCOW2: bug fix - read base image beyond its size, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 01/11] Change snapshot_blkdev hmp to use correct argument type for device, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 05/11] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 06/11] qcow2: Report error for version > 2, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 04/11] qcow2: Fix error handling for reading compressed clusters, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 08/11] qemu-img: Improve error messages for failed bdrv_open, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 09/11] blockdev: Plug memory leak in drive_uninit(), Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 10/11] blockdev: Plug memory leak in drive_init() error paths, Kevin Wolf, 2011/02/10
- [Qemu-devel] [PATCH 07/11] qed: Report error for unsupported features,
Kevin Wolf <=
- [Qemu-devel] [PATCH 11/11] qcow2: Fix order in L2 table COW, Kevin Wolf, 2011/02/10
- Re: [Qemu-devel] [PULL 00/11] Block patches for master, Anthony Liguori, 2011/02/14