[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH STABLE 0.14 4/9] qcow2: Fix error handling for readi
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH STABLE 0.14 4/9] qcow2: Fix error handling for reading compressed clusters |
Date: |
Fri, 11 Feb 2011 15:21:29 +0100 |
When reading a compressed cluster failed, qcow2 falsely returned success.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
(cherry picked from commit 8af364884355b3f0c5d60a2d2f427927739658ea)
---
block/qcow2-cluster.c | 4 ++--
block/qcow2.c | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 5fb8c66..437aaa8 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -878,11 +878,11 @@ int qcow2_decompress_cluster(BlockDriverState *bs,
uint64_t cluster_offset)
BLKDBG_EVENT(bs->file, BLKDBG_READ_COMPRESSED);
ret = bdrv_read(bs->file, coffset >> 9, s->cluster_data, nb_csectors);
if (ret < 0) {
- return -1;
+ return ret;
}
if (decompress_buffer(s->cluster_cache, s->cluster_size,
s->cluster_data + sector_offset, csize) < 0) {
- return -1;
+ return -EIO;
}
s->cluster_cache_offset = coffset;
}
diff --git a/block/qcow2.c b/block/qcow2.c
index 647c2a4..551b3c2 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -497,8 +497,10 @@ static void qcow2_aio_read_cb(void *opaque, int ret)
}
} else if (acb->cluster_offset & QCOW_OFLAG_COMPRESSED) {
/* add AIO support for compressed blocks ? */
- if (qcow2_decompress_cluster(bs, acb->cluster_offset) < 0)
+ ret = qcow2_decompress_cluster(bs, acb->cluster_offset);
+ if (ret < 0) {
goto done;
+ }
qemu_iovec_from_buffer(&acb->hd_qiov,
s->cluster_cache + index_in_cluster * 512,
--
1.7.2.3
- [Qemu-devel] [PULL STABLE 0.14 0/9] Block patches for stable-0.14, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 1/9] Change snapshot_blkdev hmp to use correct argument type for device, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 2/9] QCOW2: bug fix - read base image beyond its size, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 3/9] qcow2: Fix error handling for immediate backing file read failure, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 4/9] qcow2: Fix error handling for reading compressed clusters,
Kevin Wolf <=
- [Qemu-devel] [PATCH STABLE 0.14 5/9] qerror: Add QERR_UNKNOWN_BLOCK_FORMAT_FEATURE, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 6/9] qcow2: Report error for version > 2, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 8/9] qemu-img: Improve error messages for failed bdrv_open, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 7/9] qed: Report error for unsupported features, Kevin Wolf, 2011/02/11
- [Qemu-devel] [PATCH STABLE 0.14 9/9] qcow2: Fix order in L2 table COW, Kevin Wolf, 2011/02/11
- [Qemu-devel] Re: [PULL STABLE 0.14 0/9] Block patches for stable-0.14, Justin M. Forbes, 2011/02/11