[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper func
From: |
Nathan Froyd |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-arm: Move Neon VUZP to a helper function |
Date: |
Fri, 11 Feb 2011 09:14:54 -0800 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On Fri, Feb 11, 2011 at 05:12:32PM +0000, Peter Maydell wrote:
> On 11 February 2011 17:03, Nathan Froyd <address@hidden> wrote:
> > I do think the preferred way would be to extract rd, rm, size, and Q
> > up-front, rather than having the helper twiddle instruction bits.
>
> OK. You're happy to still have the helper do the reading and
> writing of env->vfp.regs[] directly, though?
I think you can make a case either way, but you're passing enough values
already that accessing env->vfp.regs directly in the helper seems
reasonable.
-Nathan
[Qemu-devel] [PATCH 2/2] target-arm: Move Neon VZIP to a helper function, Peter Maydell, 2011/02/11