|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""' |
Date: | Mon, 14 Feb 2011 14:56:44 +0100 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101208 Red Hat/3.1.7-3.el6_0 Thunderbird/3.1.7 |
On 02/14/11 13:10, Anthony Liguori wrote:
On 02/14/2011 04:57 AM, Gerd Hoffmann wrote:On 01/31/11 21:43, Anthony Liguori wrote:commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the change vnc password command that changed the behavior of setting the VNC password to an empty string from disabling login to disabling authentication. This commit refactors the code to eliminate this overloaded semantics in vnc_display_password and instead introduces the vnc_display_disable_login. The monitor implementation then determines the behavior of an empty or missing string.Hmm, now about simply never ever changing vs->auth?If auth is none and you do a vnc change password "" then if we don't set vs->auth to vnc, it won't have the desired effect.
If you want a password-protected vnc session you should better explicitly say so using '-vnc :0,password', otherwise you'll have a window (between qemu start and setting the password) where vnc clients can connect without a password.
Going from "none" to "vnc" automagically when setting a password encourages this insecure way to enable password protection. IMHO we should stop doing this. There are backward compatibility issues though as qemu did this for quite some time ...
Going from "vnc" to "none" automagically when setting a empty password is a no-go from a security point of view, especially as older qemu versions did *not* do that.
I don't think we'll need a monitor command to switch authentication methods on the fly. YMMV.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |