Re: [Qemu-devel] [PATCH 06/10] vmmouse: convert to qdev

[Markus Armbruster]

Anthony Liguori <address@hidden> writes:

> On 02/12/2011 11:03 AM, Markus Armbruster wrote:
>> Blue Swirl<address@hidden>  writes:
>>
>>    
>>> Convert to qdev, also add a proper reset function.
[...]
>> Pointer properties are for dirty hacks only.  Is there really no better
>> solution?  Why does it have to be a property?
>>    
>
> vmmouse is really just an extension to the PS2 Mouse.  It's definitely
> not an ISA device.
>
> In terms of qdev enablement, I would just make it a boolean option to
> the PS2Mouse and not expose it as a top level device at all.  It
> cannot exist without a PS2Mouse.

Which means making it a separate qdev is wrong.  That wrongness gave
rise to the dirty pointer property.  Pointer property serves as canary
again.

What now?


PS: Grumpy reviewer venting: review can keep such mistakes out of the
code, but it got committed less than two days after it was posted.
That, and the lack of proper reference headers bounced it several places
down my review queue.