[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] softfloat: export float32_nan and float32_i
|
From: |
Christophe Lyon |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] softfloat: export float32_nan and float32_infinity. |
|
Date: |
Wed, 16 Feb 2011 17:58:26 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7 |
On 16.02.2011 17:54, Peter Maydell wrote:
> On 16 February 2011 14:51, <address@hidden> wrote:
>> From: Christophe Lyon <address@hidden>
>>
>> These two special values are needed to implement some helper
>> functions, which return these values in some cases.
>>
>> This patch also moves the definitions of default_nan for 16, 64, x80
>> and 128 bits floats for consistency with float32.
>
> Your other patch only uses float32_infinity, not float32_nan
> or float32_default_nan, which renders a lot of this patch moot
> at the moment.
Indeed, I have another patch for vrsqrte which does need float32_nan.
>> +#define float32_nan float32_default_nan
>
> If we do need to expose NaN, we should just have callers
> use float32_default_nan, there's no need for this extra
> #define.
>