qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to specify

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to specify dtrace probe names
Date: Thu, 17 Feb 2011 13:29:27 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 
On 02/17/2011 01:19 PM, Jes Sorensen wrote:

On 02/17/11 13:16, Paolo Bonzini wrote:

On 02/15/2011 01:34 PM, address@hidden wrote:

-    if [ -z "$binary" ]; then
+    if [ -z "$probeprefix" -a -z "$binary" ]; then
          echo "--binary is required for SystemTAP tapset generator"
          exit 1
       fi


--binary is always required, even with --probe-prefix, since it is used for

+probe $probeprefix.$name = process("$binary").mark("$name")


if I broke something with this
No, you didn't break anything. It's just that someone patching the Makefile like you did in 2/2 might. 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]