|
From: | Vasily Khoruzhick |
Subject: | Re: [Qemu-devel] [PATCH] Fix obvious mistake in pxa2xx i2s driver |
Date: | Sun, 20 Feb 2011 20:39:20 +0200 |
User-agent: | KMail/1.13.6 (Linux/2.6.37-gentoo-anarsoul; KDE/4.6.0; i686; ; ) |
On Sunday 20 February 2011 20:24:46 Aurelien Jarno wrote: > The fix looks fine, but the resulting code is probably over > engineered... What about: > > s->enable = (value & 9) == 1; > > ? Looks OK to me. Regards Vasily
[Prev in Thread] | Current Thread | [Next in Thread] |