Re: [Qemu-devel] [PATCH] Network functions patches for win32

[Blue Swirl]

On Thu, Feb 10, 2011 at 11:16 AM, Pavel Dovgaluk
<address@hidden> wrote:
> This patch contains some fixes for network functions, working in Windows
> environment, and consists of two parts:
>
> 1. net/socket.c fix
>   MSDN includes the following in WSAEALREADY error description for connect()
>   function: "To preserve backward compatibility, this error is reported as
>   WSAEINVAL to Winsock applications that link to either Winsock.dll or
>   Wsock32.dll". So check of this error code was added to allow network
>   connections through the sockets in Windows.
>
> 2. net/tap-win32.c fix
>   This fix allows connection of internal VLAN to the external TAP interface.
>   If tap_win32_write function always returns 0, the TAP network interface
>   in QEMU is disabled.

Even though the changes are small, the fixes are unrelated. Please
split the patch in two. Otherwise this looks OK.