[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus |
Date: |
Wed, 23 Feb 2011 17:10:14 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 22, 2011 at 10:03:45AM -0600, Anthony Liguori wrote:
> On 02/07/2011 10:34 AM, Alon Levy wrote:
> >+static int ccid_post_load(void *opaque, int version_id)
> >+{
> >+ USBCCIDState *s = opaque;
> >+
> >+ // This must be done after usb_device_attach, which sets state to
> >ATTACHED,
> >+ // while it must be DEFAULT in order to accept packets (like it is after
> >+ // reset, but reset will reset our addr and call our reset handler which
> >+ // may change state, and we don't want to do that when migrating).
> >+ s->dev.state = s->state_vmstate;
> >+ return 0;
> >+}
> >+
> >+static void ccid_pre_save(void *opaque)
> >+{
> >+ USBCCIDState *s = opaque;
> >+
> >+ s->state_vmstate = s->dev.state;
> >+ if (s->dev.attached) {
> >+ // migrating an open device, ignore reconnection CHR_EVENT to avoid
> >an
> >+ // erronous detach.
> >+ s->migration_state = MIGRATION_MIGRATED;
> >+ }
>
>
> Still using C99 comments, should be C89.
Fixed (by checkpatch.pl iteration) in v20.
>
> Regards,
>
> Anthony Liguori
>
- [Qemu-devel] [PATCH 0/7] usb-ccid (v19), Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 2/7] introduce libcacard/vscard_common.h, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 3/7] ccid: add passthru card device, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 6/7] ccid: add docs, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 5/7] ccid: add ccid-card-emulated device, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 7/7] ccid: configure: improve --enable-smartcard flags, Alon Levy, 2011/02/07
- [Qemu-devel] [PATCH 4/7] libcacard: initial commit, Alon Levy, 2011/02/07
- Re: [Qemu-devel] [PATCH 0/7] usb-ccid (v19), Alon Levy, 2011/02/20